Avoid duplicate log entries #6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
|
Looks like |
Previously the logger would have two sinks configured (the default + our custom one). This PR clears the default logger before registering our custom one.
jcrist
force-pushed
the
dont-duplicate-logs
branch
from
9dd4e11 to
71dc1cf
Compare
|
Thanks, done. I figured there might be something I missed - I still don't have a working dev environment, so this patch wasn't even built locally :/. |
|
/ok to test |
|
All good! Hopefully we get you to one today. |
vyasr
approved these changes
Jan 15, 2025
|
/merge |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the logger would have two sinks configured (the default + our custom one). This PR clears the default logger before registering our custom one.